Ticket #1457 (new feature)
Opened 2012-09-07T11:00:21-05:00
Last modified 2013-11-19T14:18:49-06:00
Fix obviously failing commands [analysis]
| Reported by: | bdezonia | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | major | Milestone: | imagej2-b8-analysis |
| Component: | Core | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | #1313, #1336, #1431, #1433, #1605, #1756, #1769, #1813, #1841, #1852, #1856, #1881, #1888, #1903, #1904, #1908, #1910, #1922, #1930, #1948, #1958, #1961, #1964, #1966, #1972, #1973, #1981, #1986, #1990, #1992, #1993, #1994, #1995, #2002, #2005, #2006, #2008, #2014, #2015, #2019, #2020, #2022, #2028, #2029 | |
| Blocking: |
Description
Some commands in IJ2 fail in a very apparent fashion. They should be addressed preferentially. See blockers to this ticket.
Change History
comment:14 Changed 2012-10-10T13:59:53-05:00 by curtis
- Milestone changed from imagej-2.0.0-beta6 to imagej-2.0.0-beta7
comment:15 Changed 2012-10-10T14:00:01-05:00 by curtis
- Summary changed from Fix obviously failing commands (2.0.0-beta5) to Fix obviously failing commands (2.0.0-beta7)
comment:21 Changed 2012-11-21T10:22:51-06:00 by bdezonia
- Summary changed from Fix obviously failing commands (2.0.0-beta7) to Fix obviously failing commands (2.0.0-beta8)
comment:23 Changed 2012-12-06T12:52:07-06:00 by curtis
- Summary changed from Fix obviously failing commands (2.0.0-beta8) to Fix obviously failing commands [analysis]
comment:28 Changed 2013-05-28T16:41:59-05:00 by bdezonia
- Blocked By 1880 removed
(In #1880) This issue no longer apparent on the scifio-cells branch (soon to be merged)
comment:38 Changed 2013-06-04T11:45:34-05:00 by bdezonia
- Blocked By 1881 added
(In #1881) Note that scifio-cells has been merged to master.
comment:41 Changed 2013-06-05T13:09:51-05:00 by hinerm
- Blocked By 1908 added
(In #1908) Currently, these images are opened similarly using SCIFIO as in FIJI with the Bio-Formats importer.
In both cases, they are opened as RGBA. Compositing the alpha channel makes the images look off.
IJ1 seems to be taking extra steps to process the alpha channel out, and opens this as an RGB image instead.
So we need to decide how to handle alpha channels.
Also, the color table for the 4th channel is blue in IJ2 but the Bio-Formats importer and IJ1 use white.
comment:46 Changed 2013-07-18T15:35:17-05:00 by bdezonia
- Blocked By 1960 removed
(In #1960) This is an issue where the SwingInputHarvester assumes you'll never update any attributes of an existing dialog. The SwingInputHarvester could be modified so that it tied together the Module and the SwingDialog. Thus a Module would be able to update the SwingDialog when its title changes (for example). Deferring this ticket to a later beta. In the meantime I have disabled title setting code in HistogramPlot with a note explaining why.
comment:54 Changed 2013-07-31T15:47:11-05:00 by curtis
- Blocked By 1946 removed
(In #1946) This seems like a situation where the synchronizer needs to be smart about the limitations of IJ1. If the IJ2 version of the image has multiple distinct color tables, then it should certainly not overwrite all of them with the ImageJ1 color table. It would be ideal if the ImageJ1 color table could somehow be tied to the "correct" color table in ImageJ2, and then only that one would get synchronized in case of changes in ImageJ1-land. The simplest approach would be to always use the first color table of the IJ2 image for this.
In the case of the image being restructured, it becomes less clear how to maintain this mapping. But for the workflow above, no restructuring takes place—pixel values are merely zeroed out. So it might work.
However, there are many other potential compatibility issues, even if we were to employ this strategy. Because in ImageJ1-land, as you say, the color table *is* only red, and anyone expecting things being otherwise (based on their perception from the modern UI) will be disappointed.
Booting this ticket to imagej2-b10-compatibility, since we have bigger fish to fry.