Ticket #533 (closed defect: fixed)
Opened 2011-05-20T14:47:46-05:00
Last modified 2011-05-24T10:26:43-05:00
DisplayPostProcessor should not generate DatasetChangedEvents
| Reported by: | bdezonia | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | major | Milestone: |
|
| Component: | Display API | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: |
Description
We bootstrapped the display architecture on the idea that the DisplayPostProcessor would generate events as needed when a currently displayed Dataset had been run through a plugin. Nowadays the DatsetHarmonizer takes care of generating rebuild and changed events as needed. Remove DisplayPostProcessor's use of this paradigm.
Change History
comment:1 Changed 2011-05-20T14:50:24-05:00 by bdezonia
comment:2 Changed 2011-05-23T11:49:26-05:00 by curtis
- Milestone changed from biweekly-2011: May-23 to Jun-03 to biweekly-2011: May-09 to May-20
I agree that the view logic should not be generating dataset changed events. On the contrary, views should listen for dataset changed events and update themselves. This is already mostly happening (see ticket #481).
I also want to clarify that DatasetHarmonizer is part of the legacy layer (which is optional), so should not be responsible for any core event publications, other than in response to IJ1 concerns.
comment:3 Changed 2011-05-23T11:50:30-05:00 by curtis
- Milestone changed from biweekly-2011: May-09 to May-20 to biweekly-2011: May-23 to Jun-03
comment:4 Changed 2011-05-23T12:11:35-05:00 by bdezonia
Re: clarification, yes the DatasetHarmonizer only generates Dataset update/rebuild/etc. events when an ImagePlus has changed accordingly after calling a legacy plugin. In core IJ2 other Dataset events are getting published as needed.
comment:5 Changed 2011-05-24T10:26:28-05:00 by bdezonia
- Status changed from new to closed
- Resolution set to fixed
made sure dataset events getting triggered in all places they need to in IJ2. Updated Dataset as needed. All other places in code are generating events correctly.
comment:6 Changed 2011-05-24T10:26:43-05:00 by bdezonia
that closing happened in f359decec09a7720b3a5b4fe65963e76e8152442
Removed in 3d7b82954cea3a0fdd93e0472ae45372edac7793. Some testing done. To close this ticket some thorough code inspection has to happen to make sure we are generating events in all cases when Dataset, ImgPlus, or Img data is getting changed.