Ticket #1795 (closed defect: fixed)
Opened 2013-04-10T11:56:39-05:00
Last modified 2013-05-31T16:08:07-05:00
Make sure that we do not offer any files in luts/ via the updater
| Reported by: | dscho | Owned by: | dscho |
|---|---|---|---|
| Priority: | major | Milestone: |
|
| Component: | Updater | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | bdezonia, curtis | Blocked By: | |
| Blocking: | #1040, #1726, #1737, #1901 |
Description
The problem with this is that we do encourage users to put their own LUTs into the luts/ folder, even to override the default ones with their enhanced versions. But that would mark them as locally modified, suggesting that they should not have done that.
Worse: if we were to offer files in luts/ by mistake, later to mark them as obsolete, users would get red warnings about locally modified files because the updater would think that the files should not even be there, let alone modified.
The only solution, of course, is to avoid putting stuff there in the first place, instead using the method I suggested long ago: deliver default .lut files inside .jar files.
Change History
comment:1 Changed 2013-04-10T12:11:11-05:00 by bdezonia
comment:2 Changed 2013-04-10T13:25:32-05:00 by dscho
Note that I specifically said that users should be able to put things into the luts/ folder. That's the whole point of avoiding to upload files to the update site that would then label user-provided files as locally-modified or even obsolete.
comment:3 Changed 2013-04-11T10:44:06-05:00 by dscho
- Blocking 1040, 1726, 1737 added
The luts/ issue is blocking the upload of a current IJ2 revision to the update site, and hence a few other tickets which I just added.
comment:4 Changed 2013-04-11T10:59:29-05:00 by dscho
- Status changed from new to closed
- Resolution set to fixed
Fixed in f04978ab53f5d4afb9a0d301c2f19e6ff56542d4.
This seems like a developer-centric problem solution. I think it is reasonable to allow users to easily add luts without having to use jar tools. Making the updater more flexible would be a more user-friendly solution. That being said I don't know the difficulty of such a thing.