⚠	NOTICE! This is a static HTML version of a legacy ImageJ Trac ticket. The ImageJ project now uses GitHub Issues for issue tracking. Please file all new issues there.

Ticket #1656 (closed defect: fixed)

Opened 2013-02-25T12:39:45-06:00

Last modified 2013-05-31T16:11:41-05:00

Simplify updater tests

Reported by:	dscho	Owned by:	dscho
Priority:	major	Milestone:	~~imagej2-b7-ndim-data~~
Component:	Updater	Version:
Severity:	serious	Keywords:
Cc:		Blocked By:
Blocking:	#1901

Description

The updater unit tests are horribly complicated. Most of them, however, could be simplified dramatically by using the command-line updater instead.

Change History

comment:1 Changed 2013-03-07T13:02:32-06:00 by bdezonia

Milestone set to imagej2-b8-analysis

comment:2 Changed 2013-03-22T15:46:23-05:00 by dscho

Progress was made in conjunction with implementing the WebDAV uploader backend: 822c1ccff054ddfe582a73f25873afe52a4108cc

comment:3 Changed 2013-04-04T13:56:49-05:00 by dscho

Status changed from new to closed
Resolution set to fixed

Further simplifications will be done on the fly. The new https://github.com/imagej/imagej/blob/master/core/updater/src/test/java/imagej/updater/core/CommandLineUpdaterTest.java class contains much more intuitive ways to implement tests, so new tests will be added there, using the command-line updater, rather than extending https://github.com/imagej/imagej/blob/master/core/updater/src/test/java/imagej/updater/core/UpdaterTest.java.

If need be, overly complicated tests will be reimplemented in CommandLineUpdaterTest and removed from UpdaterTest. I'd rather do that only if absolutely needed, though.

Last edited 2013-04-04T13:57:07-05:00 by dscho

comment:4 Changed 2013-05-31T16:05:32-05:00 by bdezonia

Blocking 1901 added; 1347 removed

comment:5 Changed 2013-05-31T16:11:41-05:00 by bdezonia

Milestone changed from imagej2-b8-analysis to imagej2-b7-ndim-data