Ticket #1639 (closed defect: fixed)
Opened 2013-01-25T15:11:13-06:00
Last modified 2013-08-12T12:56:46-05:00
Lurking issue with axes
| Reported by: | bdezonia | Owned by: | curtis |
|---|---|---|---|
| Priority: | major | Milestone: | imagej2-b8-analysis |
| Component: | ImgLib2 | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | curtis | Blocked By: | |
| Blocking: | #1923 |
Description
Currently Imglib's ImgPlus class has a getAxisIndex(AxisType) signature. This signature implies that each axis type can only be represented once in an ImgPlus. For many types this makes sense. But I can see cases where it would not (for instance if the ImgPlus wants to have two or more axes of UNKNOWN type). Maybe we need to revisit these assumptions.
Change History
comment:1 Changed 2013-01-25T15:27:25-06:00 by curtis
comment:2 Changed 2013-03-20T11:25:33-05:00 by bdezonia
- Blocked By 822 added
- Milestone changed from imagej2-unscheduled to imagej2-b7-ndim-data
comment:5 Changed 2013-05-31T15:46:12-05:00 by bdezonia
- Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis
comment:6 Changed 2013-06-13T13:12:32-05:00 by bdezonia
- Blocking 1923 added; 1519 removed
ctrueden has ideas on how this should work for beta 8
comment:7 Changed 2013-08-09T16:51:04-05:00 by bdezonia
- Owner changed from bdezonia to curtis
- Status changed from new to assigned
ctrueden, I think you are fixing this in the img-metadata branch. assigning to you.
comment:8 Changed 2013-08-09T16:55:05-05:00 by curtis
Yep, it is already fixed on that branch. Each "unknown" axis uses a unique AxisType; the net.imglib2.meta.Axes class has an unknown() method that returns a new instance, ensuring that two "unknown" axis types are never equal.
When I finally merge that branch we will be able to close this ticket.
comment:9 Changed 2013-08-12T12:53:26-05:00 by bdezonia
- Blocked By 822 removed
Fixed with imglib merge commit e4e26aa05e0f42ff1a90e8c6d67235431471de44
comment:10 Changed 2013-08-12T12:56:46-05:00 by bdezonia
- Status changed from assigned to closed
- Resolution set to fixed
I think the method should simply document that it returns the index of the *first* axis of that type. Because as you say, it is often useful to be able to ask for e.g. the X axis.