Ticket #1159 (closed defect: moved)
Opened 2012-05-08T15:48:31-05:00
Last modified 2012-08-14T12:27:04-05:00
projector::map() called too often
| Reported by: | bdezonia | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | major | Milestone: | imagej-2.0.0 |
| Component: | Display API | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1170 |
Description
Create a new 8 slice Hyperstack (1 c, 1 t). Run Stack To Images. If you put a print statement in CompositeXYProjector.map() you'll see it is called at least 106 times.
Change History
comment:2 Changed 2012-05-14T11:23:11-05:00 by bdezonia
- Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4
comment:3 Changed 2012-06-13T16:06:04-05:00 by bdezonia
More recent testing shows fewer calls (now 46). If I update DefaultImageDisplay::setPosition() to only generate AxisPositionEvents when the axis position actually changes the calls drop to 27. I did not make this change. Need to discuss further.
comment:4 Changed 2012-06-13T16:37:28-05:00 by bdezonia
With commit 30fa5e0f840e9ad50963199633f065c784676dcf the improvement from 46 to 27 is now in place. The change was not to DefaultImageDisplay::setPosition() but rather to SwingDisplayPanel::updateAxis().
This is good improvement. See what might be further done to improve things. The low limit would be 9 projector.map() calls. One for the first time the image is drawn/created and then 8 times for each creation of a new window.
comment:5 Changed 2012-06-15T11:36:19-05:00 by bdezonia
Commit 8781251be80b6c1c5bfc159ed1f2bc96e1ebb65c undoes the previous commit. The previous commit caused bug #1218
comment:6 Changed 2012-08-14T12:27:04-05:00 by bdezonia
- Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0
comment:7 Changed 2014-12-18T12:51:03-06:00 by curtis
- Status changed from new to closed
- Resolution set to moved