Ticket #1099 (closed defect: fixed)
Opened 2012-04-13T11:20:26-05:00
Last modified 2013-07-03T14:40:57-05:00
Brightness and Contrast lacks a histogram
| Reported by: | bdezonia | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | minor | Milestone: | imagej2-b8-analysis |
| Component: | Plugins | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | sapristi@…, Michael.Cammer@… | Blocked By: | |
| Blocking: | #1100 |
Description
In the imagej devel mainling list Albert Cardona noted the following about the Brightness/Contrast dialog:
- lacks a histogram
- moving the sliders feels jumpy
- the image is refreshed either slow or not frequently enough, giving the appearance of a slow operation.
Change History
comment:1 Changed 2012-04-13T11:20:51-05:00 by bdezonia
- Summary changed from Briaghtness and Contrast dialog issues to Brightness and Contrast dialog issues
comment:3 Changed 2012-07-12T17:06:39-05:00 by curtis
- Milestone changed from imagej-2.0.0-beta3 to imagej-2.0.0-beta4
comment:5 Changed 2012-09-06T14:26:19-05:00 by curtis
- Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta5
comment:6 Changed 2013-04-12T14:35:26-05:00 by bdezonia
- Cc Michael.Cammer@… added
The performance issues have been hatched in their own ticket. See #1804.
The meat of this ticket now is that it lacks a histogram. This has also been mentioned by Michael Cammer
comment:7 Changed 2013-04-12T14:49:51-05:00 by bdezonia
We are waiting for the histograms branch of Imglib to be merged before proceeding. We'll need to make a Histogram input widget associated with an Imglib2 Histogram. Then image's Histogram can be computed by the plugin and displayed by the widget. The widget might need little more api than the ability to draw lines over the top of it. It might be desirable to use the chart returned by the HistogramPlot dialog (breaking that out into an ui agnostic charting package used by both plugins). There is such a ticket elsewhere.
comment:8 Changed 2013-06-04T12:42:20-05:00 by bdezonia
- Milestone changed from imagej2-b7-ndim-data to imagej2-b8-analysis
comment:9 Changed 2013-06-24T15:27:01-05:00 by curtis
- Owner changed from curtis to bdezonia
- Status changed from new to assigned
- Summary changed from Brightness and Contrast dialog issues to Brightness and Contrast lacks a histogram
The charting service ticket is #1117. It is not a priority for ImageJ 2.0.0, but soon after. Fortunately, to address this ticket we do not need a charting service. We only need a histogram widget that can be used when a command has a @Parameter histogram. Assigning this ticket to bdezonia, since better histograms is one of his projects.
comment:10 Changed 2013-07-01T13:54:01-05:00 by bdezonia
The HistogramWidget is done and merged to master. These widgets are created when you declare a HistogramBundle @Parameter in a Command implementation. The HistogramWidget is currently enableded in the Adjust Threshold and Histogram Plot commands. A HistogramBundle needs to be incorporated into the Brightness/Contrast plugin.
comment:11 Changed 2013-07-03T10:58:09-05:00 by bdezonia
On the bc-histogram branch is an implementation of B&C with a histogram included. It needs testing and perhaps enhancement before merging to master.
comment:12 Changed 2013-07-03T14:40:57-05:00 by bdezonia
- Status changed from assigned to closed
- Resolution set to fixed
Merged. Closing.