Ticket #561 (closed task: fixed)
Opened 2011-06-02T16:45:38-05:00
Last modified 2011-11-09T14:05:42-06:00
Test: can GrayscaleTranslator ever make a COLOR or GRAYSCALE CompositeImage?
| Reported by: | bdezonia | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | major | Milestone: |
|
| Component: | Legacy Compatibility | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: |
Description
Code inspection leads me to believe that the legacy layer (via GrayscaleImageTranslator) can never create CompositeImages of type COLOR or GRAYSCALE. Test that indeed this is the case.
Currently the code avoids using DatasetView::getColorMode() as we may have may unviewed Datasets we want to go to IJ1.
If the current logic is problematic maybe adapting BioFormats' Colorizer code can help.
Change History
comment:1 Changed 2011-06-03T10:42:55-05:00 by bdezonia
comment:2 Changed 2011-06-03T11:59:25-05:00 by bdezonia
Note I think you can't make a COMPOSITE CompositeImage because that case only arises if the LUTs passed to the setImagePlusLuts() method are null or empty. I think the view code that serves the LUTs never returns a null or empty list of LUTs.
comment:3 Changed 2011-07-29T14:06:30-05:00 by bdezonia
- Milestone changed from biweekly-2011: Jul-18 to Jul-29 to imagej-2.0-beta1
comment:4 Changed 2011-11-09T13:28:55-06:00 by bdezonia
With numerous changes in legacy layer these comments now apply to ColorTableHarmonizer setCompositeImageLuts()
comment:5 Changed 2011-11-09T14:05:42-06:00 by bdezonia
- Status changed from new to closed
- Resolution set to fixed
Fixed in 8a85b4f4240ad6d37a0a53ac50804880dc98718a
Improved logic some in a4ddd667de77859362c068b8efe76b43cf9f409e after reviewing BioFOrmats' Colorizer code. Now it seems that you can't make a COMPOSITE image. Will look into this further.